Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set SCSI controller type to unknown when nil #1188

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

bill-rich
Copy link
Contributor

There can be fewer controllers than expected when deploying from content library or ovf. Setting the controller type to unknown will block further use without crashing.

@bill-rich bill-rich requested a review from a team August 27, 2020 00:05
@ghost ghost added the size/xs Relative Sizing: Extra-Small label Aug 27, 2020
@bill-rich bill-rich added the bug Type: Bug label Aug 27, 2020
@bill-rich bill-rich merged commit baa5bd1 into master Aug 31, 2020
@bill-rich bill-rich deleted the b-set_scsi_to_unknown_if_nil branch August 31, 2020 21:44
@lmayorga1980
Copy link

I don't think this is fixing the issue

provider "vsphere" {
  user                 = var.vsphere_user
  password             = var.vsphere_password
  vsphere_server       = var.vsphere_server
  allow_unverified_ssl = true
}

data "vsphere_datacenter" "dc" {
  name = "LABDC"
}

data "vsphere_datastore" "datastore" {
  name          = "MYLAB01"
  datacenter_id = data.vsphere_datacenter.dc.id
}

data "vsphere_resource_pool" "pool" {
  name          = "CLUSTERLAB/Resources"
  datacenter_id = data.vsphere_datacenter.dc.id
}

data "vsphere_network" "network" {
  name          = "VM-123"
  datacenter_id = data.vsphere_datacenter.dc.id
}

data "vsphere_virtual_machine" "template" {
  name          = "vmware-vm-centos82"
  datacenter_id = data.vsphere_datacenter.dc.id
}

I am having an issue with either specifying a VSphere VM Template(Offline) or a VSphere VM(Offline) and I am not trying to create a VM yet.

It crashes with the snippet

data "vsphere_virtual_machine" "template" {
  name          = "vmware-vm-centos82"
  datacenter_id = data.vsphere_datacenter.dc.id
}

@lmayorga1980
Copy link

Fixed on 1.24
Screen Shot 2020-09-02 at 7 46 10 PM

@ghost
Copy link

ghost commented Oct 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 10, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug Type: Bug size/xs Relative Sizing: Extra-Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants