Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

r/content__library_item: Local upload, OVA, and vm-template sources #1196

Merged
merged 2 commits into from
Sep 2, 2020

Conversation

bill-rich
Copy link
Contributor

No description provided.

@ghost ghost added size/xl Relative Sizing: Extra-Large documentation Type: Documentation labels Sep 1, 2020
@bill-rich bill-rich requested a review from a team September 1, 2020 21:58
Copy link
Contributor

@koikonom koikonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, LGTM otherwise

}()
uploadSession.UploadSession = session
defer func() {
_ = clm.CompleteLibraryItemUpdateSession(ctx, session)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this called twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should only be one. I made a copy/paste error when splitting the PRs. Got it fixed.

@bill-rich bill-rich force-pushed the f-content_library_item_features branch from 32b9e5f to 6739d6c Compare September 2, 2020 17:03
@bill-rich bill-rich merged commit 19c0d81 into master Sep 2, 2020
@bill-rich bill-rich deleted the f-content_library_item_features branch September 2, 2020 17:08
@ghost
Copy link

ghost commented Oct 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 10, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
documentation Type: Documentation size/xl Relative Sizing: Extra-Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants