enhance: Add extra_config_reboot_required to r/virtual_machine

vsphere/resource_vsphere_virtual_machine_test.go

@@ -1027,6 +1027,14 @@ func TestAccResourceVSphereVirtualMachine_extraConfig(t *testing.T) {
 					testAccResourceVSphereVirtualMachineCheckExtraConfig("foo", "bar"),
 				),
 			},
+			{
+				Config: testAccResourceVSphereVirtualMachineConfigExtraConfig("foo", "baz"),
+				Check: resource.ComposeTestCheckFunc(
+					testAccResourceVSphereVirtualMachineCheckExists(true),
+					resource.TestCheckResourceAttr("vsphere_virtual_machine.vm", "reboot_required", "false"),
+					testAccResourceVSphereVirtualMachineCheckExtraConfig("foo", "baz"),
+				),
+			},
 		},
 	})
 }
@@ -4544,6 +4552,7 @@ resource "vsphere_virtual_machine" "vm" {
   extra_config = {
     %s = "%s"
   }
+  extra_config_reboot_required = false
 
   network_interface {
     network_id = "${data.vsphere_network.network1.id}"

vsphere/virtual_machine_config_structure.go

@@ -300,6 +300,12 @@ func schemaVirtualMachineConfigSpec() map[string]*schema.Schema {
 			Description: "Extra configuration data for this virtual machine. Can be used to supply advanced parameters not normally in configuration, such as instance metadata, or configuration data for OVF images.",
 			Elem:        &schema.Schema{Type: schema.TypeString},
 		},
+		"extra_config_reboot_required": {
+			Type:        schema.TypeBool,
+			Optional:    true,
+			Default:     true,
+			Description: "Allow the virtual machine to be rebooted when a change to `extra_config` occurs.",
+		},
 		"replace_trigger": {
 			Type:        schema.TypeString,
 			Optional:    true,
@@ -579,7 +585,13 @@ func expandExtraConfig(d *schema.ResourceData) []types.BaseOptionValue {
 		// While there's a possibility that modification of some settings in
 		// extraConfig may not require a restart, there's no real way for us to
 		// know, hence we just default to requiring a reboot here.
-		_ = d.Set("reboot_required", true)
+		rebootRequired := true
+		// Check for an override to the default reboot when changes are made to the extraConfig.
+		_rebootRequired, ok := d.Get("extra_config_reboot_required").(bool)
+		if ok {
+			rebootRequired = _rebootRequired
+		}
+		_ = d.Set("reboot_required", rebootRequired)
 	} else {
 		// There's no change here, so we might as well just return a nil set, which
 		// is a no-op for modification of extraConfig.

website/docs/r/virtual_machine.html.markdown

@@ -616,6 +616,8 @@ The following options are general virtual machine and provider workflow options:
 
 * `clone` - (Optional) When specified, the virtual machine will be created as a clone of a specified template. Optional customization options can be submitted for the resource. See [creating a virtual machine from a template](#creating-a-virtual-machine-from-a-template) for more information.
 
+* `extra_config_reboot_required` - (Optional) Allow the virtual machine to be rebooted when a change to `extra_config` occurs. Default: `true`.
+
 * `custom_attributes` - (Optional) Map of custom attribute ids to attribute value strings to set for virtual machine. Please refer to the [`vsphere_custom_attributes`][docs-setting-custom-attributes] resource for more information on setting custom attributes.
 
 [docs-setting-custom-attributes]: /docs/providers/vsphere/r/custom_attribute.html#using-custom-attributes-in-a-supported-resource