Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Windows VM configuration options to resource_vsphere_virtual_machine #212

Closed
wants to merge 3 commits into from

Conversation

mahcsig
Copy link

@mahcsig mahcsig commented Oct 18, 2017

I have added options for the AutoLogon and FirstLogonCommands for Windows guest customization.
I also made the registered user and organization configurable.
I was going to add in the ChangeSID option, but it seems to always change the SID whether the option is passed or not, and whether a True or False are passed, so I left it out.

I would like to clean up the code at 2340 of vsphere/resource_vsphere_virtual_machine.go but I couldn't find a way to not pass in the guiRunOnce with no passed in run_once commands and not have it fail. Passing an empty array to CustomizationSysprep.GuiRunOnce fails on the vSphere side. Any tips to fix that workaround would be appreciated.

@mahcsig mahcsig changed the title [WIP] Add Windows VM configuration options to resource_vsphere_virtual_machine Add Windows VM configuration options to resource_vsphere_virtual_machine Nov 10, 2017
@dhekimian
Copy link
Contributor

@vancluever Pinging you to check on the process to get this merged.

Please Advise.

@vancluever
Copy link
Contributor

Hey @dhekimian and @mahcsig,

Sorry for not getting to this when it was first submitted. As a part of the coming changes to the resource in general, we have added a more comprehensive list of customization options. Included with this is the above windows configuration options (we even expose the field in the customization spec that allows you to supply your own answer file).

Since the new feature set covers these options, for clarification sake I'm going to close out this PR. The new resource is nearly complete and will be in review soon, and should be out in the next few weeks.

Thanks, sorry for the delay, and thanks for your contribution @mahcsig!

@vancluever vancluever closed this Nov 14, 2017
@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants