Add Windows VM configuration options to resource_vsphere_virtual_machine #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added options for the AutoLogon and FirstLogonCommands for Windows guest customization.
I also made the registered user and organization configurable.
I was going to add in the ChangeSID option, but it seems to always change the SID whether the option is passed or not, and whether a True or False are passed, so I left it out.
I would like to clean up the code at 2340 of
vsphere/resource_vsphere_virtual_machine.go
but I couldn't find a way to not pass in theguiRunOnce
with no passed inrun_once
commands and not have it fail. Passing an empty array toCustomizationSysprep.GuiRunOnce
fails on the vSphere side. Any tips to fix that workaround would be appreciated.