Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: r/vsphere_host thumbprint error #2266

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: r/vsphere_host thumbprint error #2266

merged 1 commit into from
Oct 8, 2024

Conversation

burnsjared0415
Copy link
Collaborator

@burnsjared0415 burnsjared0415 commented Sep 19, 2024 •
edited
Loading

Description

Adds validation of the ESXI host thumbprint before adding the host to a cluster or vCenter Server.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?
Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccResourceVSphereHost_rootFolder$ github.com/hashicorp/terraform-provider-vsphere/vsphere

ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere	0.900s

Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccResourceVSphereHost_connection$ github.com/hashicorp/terraform-provider-vsphere/vsphere

ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere	0.907s

Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccResourceVSphereHost_maintenance$ github.com/hashicorp/terraform-provider-vsphere/vsphere

ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere	0.950s

Release Note

resource/vsphere_host: Adds validation of the ESXI host thumbprint before adding the host to a cluster or vCenter Server.

References

Closes #1549

@github-actions github-actions bot added provider Type: Provider needs-review Status: Pull Request Needs Review labels Sep 19, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 19, 2024
View reviewed changes
vsphere/resource_vsphere_host.go Fixed Show resolved Hide resolved
@tenthirtyam tenthirtyam force-pushed the fix/r_vsphere_host-thumbprint-issue branch from 630a95b to 4846d5a Compare September 19, 2024 17:21
@tenthirtyam tenthirtyam changed the title fix: r/vsphere_host fix Thumbprint error fix: r/vsphere_host thumbprint error Sep 19, 2024
@tenthirtyam tenthirtyam added this to the v2.9.3 milestone Sep 19, 2024
tenthirtyam
tenthirtyam requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits and question if we can get the InsecureSkipVerify based insecure_connection in the provider configuration.

vsphere/resource_vsphere_host.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_host.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_host.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_host.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_host.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_host.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_host.go Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam added bug Type: Bug area/host Area: Host and removed needs-review Status: Pull Request Needs Review labels Sep 19, 2024
@github-actions github-actions bot added documentation Type: Documentation needs-review Status: Pull Request Needs Review labels Sep 20, 2024
@burnsjared0415 burnsjared0415 force-pushed the fix/r_vsphere_host-thumbprint-issue branch from b9ec9bf to 5931781 Compare September 20, 2024 20:24
@tenthirtyam tenthirtyam force-pushed the fix/r_vsphere_host-thumbprint-issue branch 4 times, most recently from 16415fd to 4b92dab Compare September 23, 2024 14:12
@tenthirtyam tenthirtyam self-requested a review September 23, 2024 14:12
@tenthirtyam tenthirtyam marked this pull request as ready for review September 23, 2024 14:12
@tenthirtyam tenthirtyam requested a review from a team as a code owner September 23, 2024 14:12
@tenthirtyam tenthirtyam force-pushed the fix/r_vsphere_host-thumbprint-issue branch 3 times, most recently from 2c08412 to b95fb9e Compare September 23, 2024 14:35
tenthirtyam
tenthirtyam approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Sep 23, 2024
@burnsjared0415 burnsjared0415 force-pushed the fix/r_vsphere_host-thumbprint-issue branch from b95fb9e to dc8f81f Compare September 25, 2024 14:23
@github-actions github-actions bot added the needs-review Status: Pull Request Needs Review label Sep 25, 2024
@tenthirtyam tenthirtyam marked this pull request as draft September 25, 2024 16:25
@tenthirtyam
Copy link
Collaborator

Reset to draft.

@burnsjared0415 burnsjared0415 force-pushed the fix/r_vsphere_host-thumbprint-issue branch from dc8f81f to 00536e1 Compare September 25, 2024 20:00
@burnsjared0415 burnsjared0415 marked this pull request as ready for review October 4, 2024 12:42
@tenthirtyam tenthirtyam force-pushed the fix/r_vsphere_host-thumbprint-issue branch from 00536e1 to 653f2d6 Compare October 7, 2024 20:12
@burnsjared0415 @tenthirtyam
fix: r/vsphere_host thumbprint error
dc13fda 
Adds validation of the ESXI host thumbprint before adding the host to a cluster or vCenter Server.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the fix/r_vsphere_host-thumbprint-issue branch from 653f2d6 to dc13fda Compare October 8, 2024 16:40
@tenthirtyam tenthirtyam merged commit c734c4d into hashicorp:main Oct 8, 2024
4 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

This functionality has been released in v2.9.3 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Oct 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

This functionality has been released in v2.9.3 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@spacegospod spacegospod Awaiting requested review from spacegospod

@tenthirtyam tenthirtyam Awaiting requested review from tenthirtyam

@iBrandyJackson iBrandyJackson Awaiting requested review from iBrandyJackson

Assignees

@burnsjared0415 burnsjared0415

Labels
area/host Area: Host bug Type: Bug documentation Type: Documentation provider Type: Provider
Projects
None yet
Milestone
v2.9.3
Development

Successfully merging this pull request may close these issues.

vsphere_host does not check thumbprint
3 participants
@burnsjared0415 @tenthirtyam @iBrandyJackson