feat: add support for NVMe controllers

[spacegospod]

Description

Overview

vSphere supports 4 types of device controllers on VMs - SCSI, IDE, SATA and NVMe.
NVMe was added with vSphere 6.5 but is still not supported by the terraform provider.

This PR contains code changes that allow the addition of NVMe controllers to new and existing VMs as well as disk assignment to such controllers.

NVMe controller details

The maximum number of NVMe controllers on a VM is 4 and the maximum number of devices on one controller is 64.
As with the other 3 controller types increases in the number of controllers are supported but decreases have no effect and do not delete devices on the machine.

Interface changes

r/virtual_machine - added a new input property nvme_controller_count. The value of this property indicates the number of controllers that will be created on the machine.
d/virtual_machine - added a new input property nvme_controller_scan_count. It functions identically to the scan properties for the other controller types. Used to scan for assigned disks.
subresource/virtual_disk - controller_type now supports a new value nvme

Known issues

The default value for controller_type is scsi and it overrides the actual value when importing a virtual machine.
To properly remediate this problem the default needs to be removed and controller_type needs to be a required property for virtual disks. This would constitute a breaking change and would push the potential deployment of NVMe support to the next major release.

Additional minor change

Removed the references to an non-existing property vtpm_present that cause nil pointer references during various VM operations.

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Ran TestAccResourceVSphereVirtualMachine_basic as a sanity check.
Added a new test case TestAccResourceVSphereVirtualMachine_nvmeController that creates 2 NVMe controllers on a VM and attaches a disk to one of them

=== RUN   TestAccResourceVSphereVirtualMachine_basic
--- PASS: TestAccResourceVSphereVirtualMachine_basic (105.76s)
=== RUN   TestAccResourceVSphereVirtualMachine_nvmeController
--- PASS: TestAccResourceVSphereVirtualMachine_nvmeController (93.00s)
PASS

Manually tested the data source and the import scenario (see the "Known issues" section)

Release Note

Release note for CHANGELOG:

Add support for NVMe controllers

References

Closes #1276

[tenthirtyam]

Looks really good! Closes the top enhancement request.

[tenthirtyam]

Reverting #2315 in an ammend since there was a breaking change we can address later.

[github-actions]

This functionality has been released in v2.11.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!