Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes #213 by allowing spaces in the datastore name using regexp. #242

Closed
wants to merge 1 commit into from

Conversation

tigelane
Copy link

No description provided.

@vancluever
Copy link
Contributor

vancluever commented Nov 17, 2017

Hey @tigelane, thanks for the PR.

We have been working on a new version of the vsphere_virtual_machine resource (PR #244) that moves the functionality of parsing the composite datastore/path file names into the DataStorePath object in govmomi.

Looking at the code for FromString, this should ultimately fix the issue by moving to upstream behaviour.

Going to close this one considering. Thanks for taking the time to look into it however!

@vancluever vancluever closed this Nov 17, 2017
@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants