Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

tests: Add missing ENV variable checks #758

Merged
merged 2 commits into from
May 7, 2019
Merged

tests: Add missing ENV variable checks #758

merged 2 commits into from
May 7, 2019

Conversation

radeksimko
Copy link
Member

Previously these tests would fail if the ENV variables aren't set, which is presumably not desirable, according to checks in all other test cases.

@radeksimko radeksimko requested a review from a team May 7, 2019 13:47
@ghost ghost added the size/s Relative Sizing: Small label May 7, 2019
@radeksimko radeksimko changed the title Add missing ENV variable checks tests: Add missing ENV variable checks May 7, 2019
bill-rich
bill-rich approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching those!

@radeksimko radeksimko merged commit e86f265 into master May 7, 2019
@radeksimko radeksimko deleted the t-variable-checks branch May 7, 2019 17:18
@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@bill-rich bill-rich bill-rich approved these changes

Assignees
No one assigned
Labels
size/s Relative Sizing: Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @bill-rich