Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unmount ISO when switching CDROM backends for a VM #920

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Conversation

koikonom
Copy link
Contributor

@koikonom koikonom commented Dec 3, 2019

If the guest OS mounts the virtual cdrom device then vsphere expects
someone to confirm that it should be "unlocked" first.

This is done via a VirtualMachineQuestionInfo object that we need to
find and then respond to via the "AnswerVM" method. We start a goroutine
right before we attempt any VM modifications and signal we're done right
after we're done. If a known question appears in the mean time, we will
send the appropriate answer.

If the guest OS mounts the virtual cdrom device then vsphere expects
someone to confirm that it should be "unlocked" first.

This is done via a VirtualMachineQuestionInfo object that we need to
find and then respond to via the "AnswerVM" method. We start a goroutine
right before we attempt any VM modifications and signal we're done right
after we're done. If a known question appears in the mean time, we will
send the appropriate answer.
@koikonom koikonom requested a review from a team December 3, 2019 16:03
@ghost ghost added the size/s Relative Sizing: Small label Dec 3, 2019
@koikonom koikonom merged commit 861f95e into master Dec 3, 2019
@koikonom koikonom deleted the cdrom_questions branch December 3, 2019 16:36
@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
size/s Relative Sizing: Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants