Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

registry: configurable client timeout #24259

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

findkim
Copy link
Contributor

@findkim findkim commented Mar 3, 2020

This PR introduces no breaking changes. It adds the option to configure the remote registry client timeout duration with the environment variable TF_REGISTRY_CLIENT_TIMEOUT. This may be useful during extraneous circumstances to mediate server issues with the remote registry.

@ghost ghost added the sdkv1 [PRs only] Marks changes that may potentially need to be ported to the plugi nSDK label Mar 3, 2020
Copy link
Contributor

@alisdair alisdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me! I think I found a minor problem in the test cleanup, so I left a comment inline.

@findkim findkim force-pushed the registry-timeout branch from d62b6fb to a954c03 Compare March 3, 2020 19:45
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #24259 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted Files Coverage Δ
terraform/evaluate.go 41.26% <0.00%> (-0.66%) ⬇️
states/statefile/version4.go 55.07% <0.00%> (-0.26%) ⬇️
states/statemgr/filesystem.go 55.64% <0.00%> (+0.83%) ⬆️

findkim added 2 commits March 5, 2020 10:14
    Fix env test cleanup

    Co-Authored-By: Alisdair McDiarmid <alisdair@users.noreply.github.com>
@findkim findkim force-pushed the registry-timeout branch from a954c03 to 8ad842d Compare March 5, 2020 16:14
@findkim findkim merged commit d88729d into hashicorp:master Mar 5, 2020
findkim added a commit that referenced this pull request Mar 5, 2020
* registry: configurable client timeout

* Update registry/client_test.go

    Fix env test cleanup

    Co-Authored-By: Alisdair McDiarmid <alisdair@users.noreply.github.com>
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
sdkv1 [PRs only] Marks changes that may potentially need to be ported to the plugi nSDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants