Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build: add circleci config #24759

Merged
merged 4 commits into from
Apr 24, 2020
Merged

build: add circleci config #24759

merged 4 commits into from
Apr 24, 2020

Conversation

mildwonkey
Copy link
Contributor

We may or may not have another 0.12 release, so let's get this in place just in case.

@pselle
Copy link
Contributor

pselle commented Apr 24, 2020

@mildwonkey Smart. Do you think the tests might be failing because of Go versions?

@mildwonkey
Copy link
Contributor Author

@pselle yeah, and somewhat unfortunately configuring the correct version lead to more failures 😂 I'll figure this out then re-request review, sorry for the noise!

@mildwonkey mildwonkey removed the request for review from a team April 24, 2020 14:20
@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

❗ No coverage uploaded for pull request base (v0.12@a216d03). Click here to learn what that means.
The diff coverage is n/a.

@mildwonkey mildwonkey requested a review from a team April 24, 2020 14:37
@mildwonkey
Copy link
Contributor Author

There we go, take two 😀

add v0.12 to slack notification `only_for_branches`
@mildwonkey mildwonkey merged commit f2ea103 into v0.12 Apr 24, 2020
@mildwonkey mildwonkey deleted the mildwonkey/v12-circleci branch April 24, 2020 18:47
@ghost
Copy link

ghost commented May 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 25, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants