build: Use Go 1.19 for Terraform v1.3 #31655
Conversation
|
The Vercel build error here seems to be unrelated to this change and is complaining about an Update: I re-ran it and the failure went away. |
|
Apparently something we're running in our code consistency checks is blocking us from using the deprecated functions in As discussed over in #31357, we were not planning to do a mass-update of those all at once in order to avoid suddently creating merge conflict hell for ourselves in case we need to backport to older Terraform versions. It seems that in order to proceed here we'll need to either change that decision or change the configuration of this checking tool to permit us to continue using these deprecated functions. I would personally lean towards the latter, especially if we can combine it with some settings in our own editors to mark the deprecations as warnings so we can easily identify opportunities to improve when we're already in the area changing some nearby code anyway. But I'm not sure how practical either of those is, so will need to investigate further. |
|
We can add |
|
I think retaining our existing policy ought to be the "default" answer here and so I've pushed a new commit to change the We could still change the policy, but if we do that then it'll be in a separate PR which can both re-enable this rule in |
Go 1.19's "fmt" has some awareness of the new doc comment formatting conventions and adjusts the presentation of the source comments to make it clearer how godoc would interpret them. Therefore this commit includes various updates made by "go fmt" to acheve that. In line with our usual convention that we make stylistic/grammar/spelling tweaks typically only when we're "in the area" changing something else anyway, I also took this opportunity to review most of the comments that this updated to see if there were any other opportunities to improve them.
Because we maintain multiple versions of Terraform across different release branches, we aim to avoid creating needless differences between the branches to maximize the chance of successful automatic backporting. Part of that policy is that we don't make cross-cutting changes to respond to deprecation of functions in upstream packages and instead we respond to them gradually over time when we'd be changing the nearby code anyway, or when new work requires using the replacement APIs. In recognition of that, this turns of the staticcheck rule that would otherwise force us to resolve all deprecations before moving forward with any other change.
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This will cause our official releases for the forthcoming v1.3 series to be built with Go 1.19 instead of Go 1.18 as before. This is in line with our usual policy of adopting the latest Go minor release available at the time when we freeze each Terraform minor release.
Go 1.19's "fmt" has some awareness of the new doc comment formatting conventions and adjusts the presentation of the source comments to make it clearer how godoc would interpret them. Therefore this commit includes various updates made by "go fmt" to acheve that.
In line with our usual convention that we make stylistic/grammar/spelling tweaks typically only when we're "in the area" changing something else anyway, I also took this opportunity to review most of the comments that this updated to see if there were any other opportunities to improve them.
I intend to include the following in our own changelog to pass on a relevant caveat from the Go 1.19 Release Notes:
When making requests to HTTPS servers, Terraform will now reject invalid handshakes that have duplicate extensions, as required by RFC 5246 section 7.4.1.4 and RFC 8446 section 4.2. This may cause new errors when interacting with existing buggy or misconfigured TLS servers, but should not affect correct servers.
This only applies to requests made directly by Terraform CLI, such as provider installation and remote state storage. Terraform providers are separate programs which decide their own policy for handling of TLS handshakes.
There is also a change that might affect Terraform's visible behavior, but I think not in a way that's significant enough to call out explicitly: