RSync folder synchonization on Windows isn't compatible with MSYS-port of RSync #3804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
added a commit
that referenced
this pull request
May 17, 2014
|
Thanks! I fixed this a bit deeper in the core that should help. |
|
Thanks! Additionally I had to fix vagrant-vsphere plugin, as it doesn't reuse this code from Vagrant core yet. |
ghost
locked and limited conversation to collaborators
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If MSYS port of RSync tool is used on Windows for folder synchronization, it fails with error
This is because MSYS expects file paths in form of
/c/Users/michael.kuzmin/Projects/vagrant, without leading/cygdrivepart.The pull request adds additional check for this case.
Also it would be great if you reopen #3236 and bundle rsync and openssh right in Vagrant installer.
That would significantly simplify Vagrant adoption by developers in our company.