Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(metrics): sidecar injection false positives #716

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

gsantos-hc
Copy link
Contributor

Do not increment the injections_by_namespace metric when no injection is performed.

Do not increment the `injections_by_namespace` metric when no injection
is performed.
@gsantos-hc gsantos-hc requested a review from a team as a code owner December 12, 2024 19:48
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benashz benashz merged commit 9f0f1bc into hashicorp:main Dec 12, 2024
2 checks passed
@tvoran tvoran added this to the 1.6.1 milestone Dec 16, 2024
@tvoran tvoran added injector metrics bug Something isn't working labels Dec 16, 2024
@gsantos-hc gsantos-hc deleted the fix/metrics-injection-counts branch January 22, 2025 19:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working injector metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants