Fixes UI for implicit flow by adding required source to postMessage #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austingebauer
requested review from
calvn,
fairclothjm,
robmonte and
hashishaw
calvn
approved these changes
Dec 20, 2021
|
Thanks for looking into this and the quick fix Austin! |
austingebauer
added a commit
that referenced
this pull request
Dec 21, 2021
austingebauer
added a commit
that referenced
this pull request
Dec 21, 2021
This was referenced Dec 21, 2021
austingebauer
added a commit
that referenced
this pull request
Dec 21, 2021
austingebauer
added a commit
that referenced
this pull request
Dec 21, 2021
austingebauer
added a commit
that referenced
this pull request
Dec 21, 2021
austingebauer
added a commit
that referenced
this pull request
Dec 21, 2021
This was referenced Dec 21, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a regression introduced in Vault 1.9.1 that caused the implicit flow (
oidc_response_types=id_token) to no longer work from the Vault UI. The cause of the regression was hashicorp/vault#13133, which added a requiredsourcefield to the data sent viapostMessagebetween the window objects.Fixes hashicorp/vault#13460.
Testing
I tested that this fixes the implicit flow using Azure AD from the Vault UI.