make error responses less verbose #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austingebauer
approved these changes
Apr 19, 2023
| @@ -272,7 +273,8 @@ func (b *jwtAuthBackend) pathConfigWrite(ctx context.Context, req *logical.Reque | |||
| case config.JWKSURL != "": | |||
| keyset, err := jwt.NewJSONWebKeySet(ctx, config.JWKSURL, config.JWKSCAPEM) | |||
| if err != nil { | |||
| return logical.ErrorResponse(errwrap.Wrapf("error checking jwks_ca_pem: {{err}}", err).Error()), nil | |||
| b.Logger().Error("error checking jwks_ca_pem", "error", err) | |||
There was a problem hiding this comment.
I realize it was like this before, but I think this log and error should be like error checking jwks_url. I guess it could be a problem with the CA too.. So maybe error checking jwks_url or jwks_ca_pem? 🤔
There was a problem hiding this comment.
It looks like NewJSONWebKeySet() returns an error if jwks url is empty or if there is an error with the CA. On line 273 we check that the jwks url is not empty so I think this log is correct.
There was a problem hiding this comment.
You're right. Missed that we already check if it's not empty 👍
|
Thanks! |
fairclothjm
added a commit
that referenced
this pull request
Apr 20, 2023
* make error responses less verbose * fix uts
fairclothjm
added a commit
that referenced
this pull request
Apr 20, 2023
* make error responses less verbose * fix uts
jameshartig
pushed a commit
to jameshartig/vault-plugin-auth-jwt
that referenced
this pull request
May 10, 2023
* make error responses less verbose * fix uts
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.