Only use SIGTSTP on appropriate OSes #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpcraig
changed the title
maxcoulombe
approved these changes
Oct 12, 2023
vinay-gopalan
approved these changes
Oct 12, 2023
raymonstah
approved these changes
Oct 12, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #251, we added
os.Killandsyscall.SIGTSTPto the terminal interrupts we handled when terminating the listener. Unfortunately,syscall.SIGTSTPis not defined on all systems (notably, Windows).The simplest way to fix this is to use build constraints to separate the SIGTSTP-having operating systems and the non-SIGTSTP systems.
It also seems like there isn't an obvious alternative to SIGTSTP in Windows (if anyone knows...), so we just cut the behavior in the windows version.