Recover from panics during request forwarding #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gRPC doesn't have a handler for recovering from a panic like a normal HTTP request so a panic will actually kill Vault's listener. This basically copies the net/http logic for managing this. The SSH-specific logic is removed here as the underlying issue is caused by the request forwarding mechanism.
|
@jefferai the initial panic recovery worked it just was casting to the wrong type. I was able to recreate the issue and address it by casting it to a string and returning the correct error. I can't assign you as a reviewer since you created this PR. Can you take a look? |
|
Hah, ok. Perfect. Looks great! |
chrishoffman
approved these changes
Jul 28, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When request forwarding, if we have a panic, the entire connection gets killed. Instead, log an error with the panic information.
Fixes #2877
Note: fix is currently incomplete for the full issue.