Avoid unseal failure if plugin backends fail to setup during postUnseal #3686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
approved these changes
Dec 14, 2017
briankassouf
approved these changes
Dec 14, 2017
| // If we encounter an error instantiating the backend due to an error, | ||
| // skip backend initialization but register the entry to the mount table | ||
| // to preserve storage and path. | ||
| c.logger.Warn("core: skipping plugin-based credential entry", "path", entry.Path) |
There was a problem hiding this comment.
Can we output the error here so the user knows why it failed (plugin missing, bad SHA, etc.), and the same for mounts?
There was a problem hiding this comment.
The error is printed out up top in https://github.com/hashicorp/vault/pull/3686/files#diff-444ea30b36f7a95d6672fd6fd9b7a87cR461.
There was a problem hiding this comment.
Ha, I even looked there and thought "Oh, it's only printing out the path", missed the error somehow :)
chrishoffman
pushed a commit
that referenced
this pull request
Dec 15, 2017
* oss/master: Defer reader.Close that is used to determine sha256 changelog++ Avoid unseal failure if plugin backends fail to setup during postUnseal (#3686) Add logic for using Auth.Period when handling auth login/renew requests (#3677) plugins/database: use context with plugins that use database/sql package (#3691) changelog++ Fix plaintext backup in transit (#3692) Database gRPC plugins (#3666)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3602