Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Continue and warn when tidying in pki if an entry or value is nil #4214

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Continue and warn when tidying in pki if an entry or value is nil #4214

merged 1 commit into from
Mar 29, 2018

Conversation

jefferai
Copy link
Member

Ref #4177

@jefferai jefferai added this to the 0.10 milestone Mar 29, 2018
@jefferai jefferai mentioned this pull request Mar 29, 2018
Closed
calvn
calvn approved these changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@calvn calvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think handling like this is proper.

briankassouf
briankassouf approved these changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@briankassouf briankassouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jefferai jefferai merged commit 899a6e4 into master Mar 29, 2018
@jefferai jefferai deleted the issue-4177 branch March 29, 2018 19:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@briankassouf briankassouf briankassouf approved these changes

@calvn calvn calvn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@jefferai @calvn @briankassouf