Support operating on entities and groups by their names #5355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnayak
force-pushed
the
entity-by-name
branch
from
9774316 to
039db30
Compare
vishalnayak
force-pushed
the
entity-by-name
branch
from
379b6ae to
50a9c28
Compare
vishalnayak
changed the title
briankassouf
previously approved these changes
Sep 21, 2018
vault/identity_store_groups.go
Outdated
| return nil, err | ||
| } | ||
| if group.NamespaceID != ns.ID { | ||
| return nil, logical.ErrUnsupportedPath |
There was a problem hiding this comment.
I think we should return nil, nil here so it matches the case where there is no group
vault/identity_store_entities.go
Outdated
| ns, err := namespace.FromContext(ctx) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if entity.NamespaceID != ns.ID { | ||
| return nil, logical.ErrUnsupportedPath |
There was a problem hiding this comment.
Same we should return nil, nil here
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.