Added socket keep alive option (SO_KEEPALIVE) to Cassandra plugin #6201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briankassouf
approved these changes
Feb 9, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firewalls configured with an idle connection timeout can close connections between Vault and Cassandra nodes. This results in stale connection at the Vault side, because it never receives a TCP FIN packet, and regards the connection as healthy. Such stale connections cause timeouts when a Vault client reads the role for issuing new Cassandra credentials, resulting in a broken Cassandra secret engine. The SO_KEEPALIVE socket option prevents such firewalls to close connections, because the kernel at Vault side will send duplicate ACK messages every interval.
This pull request adds the
socket_keep_aliveduration option to the Cassandra plugin and solves the above issue.