Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

logical: add support for passing data to delete #7139

Merged
merged 5 commits into from
Jul 18, 2019
Merged

logical: add support for passing data to delete #7139

merged 5 commits into from
Jul 18, 2019

Conversation

calvn
Copy link
Contributor

@calvn calvn commented Jul 17, 2019

I opted for moving the query parsing into its own func instead of combining the two cases to keep the seams between read and delete cleaner.

@calvn calvn requested a review from jefferai July 17, 2019 17:57
ncabatoff
ncabatoff reviewed Jul 17, 2019
View reviewed changes
command/delete.go Outdated Show resolved Hide resolved
ncabatoff
ncabatoff previously approved these changes Jul 17, 2019
View reviewed changes
Copy link
Collaborator

@ncabatoff ncabatoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo that one error message.

@calvn calvn added this to the 1.2 milestone Jul 17, 2019
@calvn calvn merged commit 3e2cd48 into master Jul 18, 2019
@calvn calvn deleted the logical-delete-with-data branch July 18, 2019 17:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kalafut kalafut kalafut approved these changes

@jefferai jefferai jefferai approved these changes

@ncabatoff ncabatoff ncabatoff left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@calvn @jefferai @kalafut @ncabatoff