Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update the vault-helm ingress config docs #8881

Merged
merged 4 commits into from
Apr 29, 2020
Merged

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Apr 29, 2020

The chart defines the backend stanza, so the path list should just
be path strings.

Related to hashicorp/vault-helm#278

The chart defines the `backend` stanza, so the `path` list should just
be path strings.
tls.hosts is a list, not a string
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tvoran tvoran merged commit 14da940 into master Apr 29, 2020
@tvoran tvoran deleted the docs-vault-helm-ingress branch April 29, 2020 19:10
@tvoran tvoran added the docs label Apr 29, 2020
tvoran added a commit that referenced this pull request Apr 29, 2020
The chart defines the `backend` stanza, so the `path` list should
just be path strings. More typos: `tls.hosts` is a list, not a
string.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants