Add GHC-9.8.1-alpha1 #674
Merged
Add GHC-9.8.1-alpha1 #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanz
added a commit
to alanz/ghc-exactprint
that referenced
this pull request
Aug 7, 2023
alanz
added a commit
to alanz/ghc-exactprint
that referenced
this pull request
Aug 7, 2023
alanz
reviewed
Aug 7, 2023
| @@ -402,7 +409,7 @@ jobs: | |||
| echo "HCNUMVER=$HCNUMVER" >> "$GITHUB_ENV" | |||
| echo "ARG_TESTS=--enable-tests" >> "$GITHUB_ENV" | |||
| echo "ARG_BENCH=--enable-benchmarks" >> "$GITHUB_ENV" | |||
| echo "HEADHACKAGE=false" >> "$GITHUB_ENV" | |||
| if [ $((! GHCJSARITH && HCNUMVER >= 90800)) -ne 0 ] ; then echo "HEADHACKAGE=true" >> "$GITHUB_ENV" ; else echo "HEADHACKAGE=false" >> "$GITHUB_ENV" ; fi | |||
| echo "ARG_COMPILER=--$HCKIND --with-compiler=$HC" >> "$GITHUB_ENV" | |||
There was a problem hiding this comment.
I had to use
echo "ARG_COMPILER=--ghc --with-compiler=$HC" >> "$GITHUB_ENV"
for ghc-exactprint in alanz/ghc-exactprint@36f329f#diff-73f8a010e9b95aa9fe944c316576b12c2ec961272d428e38721112ecb1c1a98bR71.
This PR sets it to --GHC
|
Note also in https://github.com/alanz/ghc-exactprint/actions/runs/5789850918 that the job failed, but the overall status is succeed. |
Yes. Prerelease jobs are allowed to fail. Though that behavior probably should be configurable. |
phadej
force-pushed
the
ghc-9.8.1-alpha1
branch
from
5461a5e
to
87dcb15
Compare
alanz
added a commit
to alanz/ghc-exactprint
that referenced
this pull request
Dec 19, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.