-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Expose ghcup binary location #82
base: main
Are you sure you want to change the base?
Conversation
0a3e4b0
to
c58e932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We should verify that the -exe
outputs are absolute paths indeed (otherwise we could name it ghcup-exe
).
@@ -45,6 +45,8 @@ outputs: | |||
description: 'The resolved version of stack' | |||
ghc-exe: | |||
description: 'The path of the ghc _executable_' | |||
ghcup-command: | |||
description: 'The path of the ghcup _executable_' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We should check whether the
-exe
outputs are indeed absolute paths. - The help text here should not say "path" but something like "The command to invoke ghcup (might not be an absolute path)".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check whether the -exe outputs are indeed absolute paths.
Any hints for writing a test? I don't see right away where such a test could be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question!
There is some code in CI that validates the -version
outputs of the actions, maybe something similar could be done for the -exe
outputs:
setup/.github/workflows/workflow.yml
Lines 166 to 174 in 64f55f9
- name: Confirm resolved and installed versions match | |
shell: bash | |
run: | | |
CABALVER="$(cabal --numeric-version)" | |
GHCVER="$(ghc --numeric-version)" | |
echo "CABALVER=${CABALVER}" >> "${GITHUB_ENV}" | |
echo "GHCVER=${GHCVER}" >> "${GITHUB_ENV}" | |
if [[ "${{ steps.setup.outputs.ghc-version }}" == "latest-nightly" ]] | |
then |
Closes #81
Let the bikeshedding commence :)