Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Expr.Types: NExprF: add NApp #1042

Merged
merged 8 commits into from
Jan 21, 2022
Merged

Expr.Types: NExprF: add NApp #1042

merged 8 commits into from
Jan 21, 2022

Conversation

Anton-Latukha
Copy link
Collaborator

@Anton-Latukha Anton-Latukha commented Jan 21, 2022 •
edited
Loading

Implements #1041.

@Anton-Latukha
Expr.Types: NExprF: add NApp
9ef12ef 
This commit takes-put the NApp out of NBinaryOp & places it as a proper citizen
on NExprF.

Addresses haskell-nix#1041 &
haskell-nix#377.
@Anton-Latukha
Expr.Types: upd N{,Source}Pos instance messaging
bdf87e8 
Since this is no longer Megaparsec types - these instances are no longer orphaned.
@Anton-Latukha
Expr.Types: rm building berth NAppOp
843e2da 
It was used to simplify NApp migration.
@Anton-Latukha
Copy link
Collaborator Author

Anton-Latukha commented Jan 21, 2022 •
edited
Loading

After this, the #982 craves to be done.

@Anton-Latukha Anton-Latukha marked this pull request as ready for review January 21, 2022 21:44
@Anton-Latukha Anton-Latukha merged commit a9beaee into haskell-nix:master Jan 21, 2022
@Anton-Latukha Anton-Latukha deleted the 2022-01-21-take-NApp-out-of-NBinary branch January 21, 2022 21:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Anton-Latukha