Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Document how hls can be configured #437

Closed
jneira opened this issue Sep 26, 2020 · 1 comment · Fixed by #432
Closed

Document how hls can be configured #437

jneira opened this issue Sep 26, 2020 · 1 comment · Fixed by #432
Labels
type: enhancement New feature or request

Comments

@jneira
Copy link
Member

jneira commented Sep 26, 2020

  • Fow now the configuration section talks exclusively about the build info that hls needs to open a haskell project in a reliable way
  • However, there is nothing about the settings that final users can change from their editors/lsp clients:
    • What formatter want to use for example
    • Several options were translated from hie and they still does not make sense, so they should not be documented yet

haskell-language-server/hls-plugin-api/src/Ide/Plugin/Config.hs

Lines 44 to 54 in 84a2274

data Config =
Config
{ hlintOn :: Bool
, diagnosticsOnChange :: Bool
, maxNumberOfProblems :: Int
, diagnosticsDebounceDuration :: Int
, liquidOn :: Bool
, completionSnippetsOn :: Bool
, formatOnImportOn :: Bool
, formattingProvider :: T.Text
} deriving (Show,Eq)

@googleson78
Copy link
Contributor

Thanks! This would be great! relating #432, as it is somewhat a start on this.

@jneira jneira linked a pull request Sep 26, 2020 that will close this issue
Add docs on how to choose a formatter #432
Merged
pepeiborra added a commit that referenced this issue Dec 27, 2020
@pepeiborra
Code action to suggest adding missing imports from pkg db (#437)
5bea92f 
* Code action to suggest adding missing imports from pkg db

The implementation looks in modules loaded from the package database. It should
only look in packages declared as dependencies of the project. The package
modules are loaded lazily and are global to the HscEnv, so the success rate will
depend on what has been loaded so far in the env.

* Avoid overlapping with extend import suggestions

> import Data.Text (Text)
> foo = pack "foo"

Teach ghcide to suggest only:

"Add pack to the import list of Data.Text"

and avoid suggesting also:

"Import Data.Text (pack)"
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add docs on how to choose a formatter googleson78/haskell-language-server
2 participants
@jneira @googleson78