Skip to content

Conversation

pepeiborra
Copy link
Collaborator

NormalizedUriJSON was wrapping a NormalizedUri to add JSON encoding/decoding capabilities. This was a bad idea because NormalizedUri embeds a hash, which was not decoding cleanly. This was making some Retrie commands fail.

The Retrie plugin needs a test suite, but I don't want to embed the test suite in func-test. I have a plan to make it easy, or at least possible, to package integration test suites with plugins, but there's a few pieces missing yet

@pepeiborra pepeiborra changed the title Fix bug in Retrive "fold/unfold in local file" commands Fix bug in Retrie "fold/unfold in local file" commands Jan 12, 2021
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ailrun Ailrun added the merge me Label to trigger pull request merge label Jan 12, 2021
@mergify mergify bot merged commit 17cd0af into master Jan 13, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants