Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use the runtime ghc libdir for ghc-exactprint #1225

Merged
merged 9 commits into from
Jan 19, 2021
Merged

Conversation

jneira
Copy link
Member

@jneira jneira commented Jan 17, 2021

@jneira jneira requested a review from alanz January 18, 2021 07:39
@jneira
Copy link
Member Author

jneira commented Jan 18, 2021

But not sure how to generalize its use, being a hack

Maybe it should be set in the entry of the hls executable (Main.hs) but theoretically you could have a multicradle using different ghc's (so with different libdirs). So we have to set the mutable state in the client code.
Also, it would be nice if somebody could suggest a cheap way to synchonize the environment setEnv, unsetEnv 🙂

@jneira jneira mentioned this pull request Jan 18, 2021
Copy link
Collaborator

@alanz alanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets the job done

@jneira
Copy link
Member Author

jneira commented Jan 18, 2021

I've applied it to brittany to close #412

@jneira jneira linked an issue Jan 18, 2021 that may be closed by this pull request
@jneira jneira added the merge me Label to trigger pull request merge label Jan 18, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
component: hls-hlint-plugin merge me Label to trigger pull request merge
Projects
None yet
2 participants