Skip to content

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Feb 12, 2021

We don't want to index files on every change as this is needlessly expensive, but it is good to index them on first open so that information from the file is available in the next ghcide session.

@pepeiborra
Copy link
Collaborator

pepeiborra commented Feb 12, 2021

Are there any downsides to not reindexing FOIs?

EDIT: ignore me, I see that we already don't reindex FOIs, this change will reindex them on first open

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth adding a test?

@wz1000
Copy link
Collaborator Author

wz1000 commented Feb 12, 2021

The most straightforward test I can think of will only show observable differences when #1357 lands. I'll add a test case after that.

BTW we already do index FOIs on save.

@wz1000 wz1000 added the merge me Label to trigger pull request merge label Feb 12, 2021
@mergify mergify bot merged commit d87a5db into haskell:master Feb 13, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants