Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Separate ghcide tests and disable them for now #137

Merged
merged 1 commit into from
May 28, 2020
Merged

Separate ghcide tests and disable them for now #137

merged 1 commit into from
May 28, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented May 27, 2020

  • CI always red is not good, we have to check that them at least builds
  • I think separate tests could be useful in its own

@jneira jneira requested a review from alanz May 27, 2020 21:37
alanz
alanz approved these changes May 27, 2020
View reviewed changes
Copy link
Collaborator

@alanz alanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

This at least gives us a baseline to check PRs against

Merge when happy.

@jneira jneira merged commit b6cac64 into haskell:master May 28, 2020
@jneira jneira deleted the disable-ghcide-tests branch May 28, 2020 05:51
pepeiborra pushed a commit that referenced this pull request Dec 27, 2020
@ndmitchell @aherrmann-da
#137, make the status message clearer about what worked and what didn…
9d45eee 
…'t (#138)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alanz alanz alanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jneira @alanz