Make sure to give the correct DynFlags to the recompilation checker #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were passing the wrong DynFlags here, causing most modules with a LANGUAGE pragma to fail the recompilation check and have their interface files regenerated
pepeiborra
force-pushed
the
interface-reloading
branch
from
6351c28 to
c83dabf
Compare
|
I thought I already fixed this :( Well, I did in haskell/ghcide#891 but the rest of the changes turned out to be incorrect. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were passing the wrong DynFlags here, causing most modules with a LANGUAGE pragma to fail the recompilation check and have their interface files regenerated.