-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Extract hls-test-utils #1606
Extract hls-test-utils #1606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look really great, this was a necessary step, many thanks
we will have another package to maintain in hackage but I hope it will not change frequently (maybe if re-exported packages change?)
eval tests are failing in windows with |
I've tried the hls-eval-plugin test suite locally with no luck:
|
bde0efa
to
3a8d949
Compare
3a8d949
to
538ed68
Compare
With the migration of plugins' tests from HLS's
func-test
to their own packages, the common stanzahls-test-utils
will no loger be available in the pattern that tests of plugins were imported as sources intofunc-test
. But there are still many common functions need to be shared. Therefore, this PR extractsTest.Hls.Util
into a new packagehls-test-utils
, with some re-exported modules. Plugin test executables now can depend on this new package, rather thandata-default
,lsp-test
,tasty-*
, etc.Moreover, this PR finishes the migration of eval plugin tests.