-
-
Notifications
You must be signed in to change notification settings - Fork 390
hie-compat: Add basic support for ghc 9.0.1 #1635
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Many thanks for working on ghc-9.0.1 support 🙏 |
All of these changes are in the new PR: #1649, so I'll just close this. |
@@ -0,0 +1,371 @@ | |||
{- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be duplicated? I think it should be possible to just reexport GHC.Iface.Ext.Binary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. I just copied whatever was in the ghc-810 versions and updated it to the ghc-901 version.
Is there a reason why the circleci tests are not running? Is it waiting for something else first? |
There's nothing on the queue (even this one), so it's an actual problem. I don't know whether it's a CircleCI bug or our setting's. One possible thing to try is add one commit (or rebase this PR) so that CI check is reactivated. |
The circleci job for ead87d8 finished succesfully but the status was not changed: https://app.circleci.com/pipelines/github/haskell/haskell-language-server/3004/workflows/999e4192-a140-4e0f-a99f-ffeea46d5778 |
Mmm you are right, the merge was clean and maybe circleci has some trouble with that this time |
Is it possible to manually trigger circleci? Or should I rebase, so it can have a new chance to trigger? |
I'll do that and then it should hopefully work as soon as someone re-approves the changes |
A tiny step towards haskell#297
Maybe it didn't think it was worth re-running the CI because the merge only changed the README? It seems to run the circleci again now. |
Unfortunately circleci dont support skip builds by file globs so not sure what happened (otoh checks would be not required in that case) |
I made a three way merge between the original in GHC-8.10, GHC-9.0 and the custom version for GHC-8.10 from this package, in order to figure out what should be changed.
Perhaps we don't actually need the full fork of
HieAst.hs
for ghc-9.0, since the difference from the original is so small, so we could just reexport the original and replacemkHieFile
with the custom version.(Tiny step towards #297)