Fix ignore paths #1656
Merged
Fix ignore paths #1656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ailrun
reviewed
Apr 2, 2021
| @@ -58,33 +55,34 @@ jobs: | |||
| # ghc: '8.6.4' | |||
|
|
|||
| steps: | |||
| # Cancel queued workflows from earlier commits in this branch | |||
| - uses: fkirc/skip-duplicate-actions@master | |||
There was a problem hiding this comment.
I think we still need this step to skip unnecessary jobs started by outdated commits
There was a problem hiding this comment.
mmm does not the same action in the pre_job do all the needed work? Afaiu it does all the things and no depends on the params: https://github.com/fkirc/skip-duplicate-actions#usage-examples
There was a problem hiding this comment.
The log of a build in my branch can provide some evidence:
Did not find other workflow-runs to be cancelled
Stop backtracking at commit https://github.com/jneira/haskell-language-server/commit/3eddabf804b4a09ea07cff26f5470514b1639f50 because '.github/workflows/test.yml' are not skippable against paths '' or paths_ignore '**/docs/**,**.md,**/LICENSE,.circleci/**,install/**,nix/**'
Do not skip execution because we did not find a transferable run
https://github.com/jneira/haskell-language-server/pull/22/checks?check_run_id=2256857741
There was a problem hiding this comment.
Oh, does it work per workflow? I thought it's per job...
|
Marked as a draft as i want to get a pr in my repo cancelled properly before merge this |
Ailrun
approved these changes
Apr 3, 2021
isovector
pushed a commit
to isovector/haskell-language-server
that referenced
this pull request
Apr 5, 2021
* Skip individual steps * Skip individual steps * And needs pre_job
mergify bot
added a commit
that referenced
this pull request
Apr 6, 2021
* Start tracking provenance of stale data It's amazing how wrong this code used to be * Add some machinery for automagically updating the age * Add an applicative instance * Tracked ages makes everything much easier to reason about * Formatting * Haddock and small changes * Update haddock on IdeAction * Update to lsp-1.2 (#1631) * Update to lsp-1.2 * fix stack * fix splice plugin tests * fix tactic plugin tests * fix some tests * fix some tests * fix outline tests * hlint * fix func-test * Avoid reordering plugins (#1629) * Avoid reordering plugins Order of execution matters for notification plugins, so lets avoid unnecessary reorderings * remove duplicate plugins * fix tests * Civilized indexing progress reporting (#1633) * Civilized indexing progress reporting * optProgressStyle * Consistency: Indexing references ==> Indexing * Fix progress tests * Do not override custom user commands (#1650) Co-authored-by: Potato Hatsue <1793913507@qq.com> * Shut the Shake session on exit, instead of restarting it (#1655) Restarting the session will result in progress reporting and other messages being sent to the client, which might have already closed the stream Co-authored-by: Potato Hatsue <1793913507@qq.com> * Fix importing type operators (#1644) * Fix importing type operators * Update test * Add expected failure tests * log exceptions before killing the server (#1651) * log hiedb exceptions before killing the server * This is not the hiedb thread - fix message * Fix handler - either an error or success * additional .gitignore entries (#1659) * Fix ignore paths (#1656) * Skip individual steps * Skip individual steps * And needs pre_job * Add bounds for Diff (#1665) * Replace Barrier with MVar in lsp main (#1668) * Port UseStale to ghcide * Use the new ghcide UseStale machinery * Fix hlint complaints Co-authored-by: wz1000 <zubin.duggal@gmail.com> Co-authored-by: Pepe Iborra <pepeiborra@gmail.com> Co-authored-by: Potato Hatsue <1793913507@qq.com> Co-authored-by: Javier Neira <atreyu.bbb@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This was referenced Apr 6, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip-duplicate-actionoutcome