Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prepare 1.1.0 release #1702

Merged
merged 7 commits into from
Apr 12, 2021
Merged

Prepare 1.1.0 release #1702

merged 7 commits into from
Apr 12, 2021

Conversation

berberman
Copy link
Collaborator

I think we should release ghcide 1.2 first, no?

@jneira jneira linked an issue Apr 10, 2021 that may be closed by this pull request
@jneira
Copy link
Member

jneira commented Apr 10, 2021

I think we should release ghcide 1.2 first, no?

For the github only release, hackage releases are not required so we can delay all of them to the main hackage release (if we wish)

@pepeiborra
Copy link
Collaborator

How long will that take? I need a timely ghcide and hls-plugin-api release

@berberman
Copy link
Collaborator Author

berberman commented Apr 10, 2021

How long will that take? I need a timely ghcide and hls-plugin-api release

IMO this PR should get merged after the release of ghcide and hls-plugin-api. Bumping up ghcide's version shoud be done in another PR

@pepeiborra
Copy link
Collaborator

How long will that take? I need a timely ghcide and hls-plugin-api release

IMO this PR should after the release of ghcide and hls-plugin-api. Bumping up ghcide's version shoud be done in another PR

Should what?

@Ailrun
Copy link
Member

Ailrun commented Apr 10, 2021

"should be released/merged", I guess?

@berberman
Copy link
Collaborator Author

oops, sorry for the confusion, as @Ailrun said, I'm waiting for the release of ghcide 1.2 in this PR

@pepeiborra
Copy link
Collaborator

What's the plan for the ghcide release then? Are you going to take care of it too?

@jneira
Copy link
Member

jneira commented Apr 11, 2021

Just in case, I think @berberman, with release, want to mean bump up the version in the .cabal file (and write up the changelog or whatever), no the hackage release.

@berberman
Copy link
Collaborator Author

@pepeiborra I just open #1707 to update the changelog and bump up the version

@jneira Yeah, we could uplaod it to hackage later, after the github release of HLS

@berberman
Copy link
Collaborator Author

@isovector I added a very rough conclusion of Wingman's changes -- please feel free to point out if you think there should be some screenshots or details to illustrate the enhancements

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's an awesome changelog!

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job, as usual

@berberman berberman changed the title [WIP] Prepare 1.1.0 release Prepare 1.1.0 release Apr 12, 2021
@berberman berberman marked this pull request as ready for review April 12, 2021 08:16
@berberman berberman merged commit b085e7a into master Apr 12, 2021
@berberman berberman deleted the prepare-1.1.0 branch April 12, 2021 08:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

April 2021 Monthly Release
6 participants