-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Prepare 1.1.0 release #1702
Prepare 1.1.0 release #1702
Conversation
For the github only release, hackage releases are not required so we can delay all of them to the main hackage release (if we wish) |
How long will that take? I need a timely ghcide and hls-plugin-api release |
IMO this PR should get merged after the release of ghcide and hls-plugin-api. Bumping up ghcide's version shoud be done in another PR |
Should what? |
"should be released/merged", I guess? |
oops, sorry for the confusion, as @Ailrun said, I'm waiting for the release of ghcide 1.2 in this PR |
What's the plan for the ghcide release then? Are you going to take care of it too? |
Just in case, I think @berberman, with release, want to mean bump up the version in the .cabal file (and write up the changelog or whatever), no the hackage release. |
@pepeiborra I just open #1707 to update the changelog and bump up the version @jneira Yeah, we could uplaod it to hackage later, after the github release of HLS |
@isovector I added a very rough conclusion of Wingman's changes -- please feel free to point out if you think there should be some screenshots or details to illustrate the enhancements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's an awesome changelog!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job, as usual
I think we should release ghcide 1.2 first, no?