-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Move pragmas completion to pragmas plugin #2134
Conversation
alexnaspo
commented
Aug 28, 2021
- Move the basic pragmas completion from GCHIDE to the pragmas module
- Add closing pragmas snippet "-#}"
191414f
to
445a7fc
Compare
445a7fc
to
08b241e
Compare
@alexnaspo thanks for your contribution, i think makes sense group all pragmasrelated code together. Are not tests about pragmas completion in the ghcide test suite? They should be moved too in that case |
@jneira It looks like the functionality for pragmas completion is actually already tested in the pragmas plugin, rather than in the ghcdie test suite. example:
ghcide that need to be moved. I have edited the tests in the plugin to reflect the new functionality of closing braces
|
return empty list from logic completions when opts or pragma start fix empty list logic
630efd5
to
81791f1
Compare