Skip to content

Add ghc-8.10.7 support #2141

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 4, 2021
Merged

Add ghc-8.10.7 support #2141

merged 12 commits into from
Sep 4, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Aug 29, 2021

  • 8.10.6 did not live much time 😄
  • I am getting error about boot packages locally, building with stack:
.....
In the dependencies for ghcide-1.4.1.0:
    directory needed, but this GHC boot package has been pruned (issue #4510); you need to add the
              package explicitly to extra-deps  (latest matching version is 1.3.6.2)
    ghc-boot needed, but this GHC boot package has been pruned (issue #4510); you need to add the
             package explicitly to extra-deps  (latest matching version is 9.0.1)
    process needed, but this GHC boot package has been pruned (issue #4510); you need to add the
            package explicitly to extra-deps  (latest matching version is 1.6.13.2)
    time needed, but this GHC boot package has been pruned (issue #4510); you need to add the
         package explicitly to extra-deps  (latest matching version is 1.12)
needed since ghcide is a build target.
...
Some different approaches to resolving this:

  * Recommended action: try adding the following to your extra-deps in D:\hls\stack-8.10.7.yaml:

- directory-1.3.6.2@sha256:6e5f3e0adfe94483d5754d97d741b7d23a5e085d47176075b1955d4fa78f37aa,2811
- ghc-boot-9.0.1@sha256:dc127d8b4b43eb54167f9befd51b2948e9084b8dfc18b88728148b719fa2287c,2347
- process-1.6.13.2@sha256:9733aa8a27b3e6c0f08a87a5c7287b3b73302d396f68f5655f9990a641368e3e,2845
- time-1.9.3@sha256:8f1b5448722a12a952248b356c9eb366e351226543d9086a2da71270522d5f45,5679

Plan construction failed.

@jneira
Copy link
Member Author

jneira commented Aug 29, 2021

it needs a choco update: Mistuke/GhcChoco#16

pepeiborra
pepeiborra reviewed Aug 29, 2021
View reviewed changes
ghcide/src/Development/IDE/Core/FileStore.hs Outdated
@@ -289,7 +289,7 @@ typecheckParentsAction nfp = do
Just rs -> do
liftIO $ (log $ "Typechecking reverse dependencies for " ++ show nfp ++ ": " ++ show revs)
`catch` \(e :: SomeException) -> log (show e)
() <$ uses GetModIface rs
Copy link
Collaborator

@pepeiborra pepeiborra Aug 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to land this fix ASAP, it's blocking everything

@jneira
Copy link
Member Author

jneira commented Aug 31, 2021 •
edited
Loading

stack does not support ghc-8.10.7 yet

@jneira
Copy link
Member Author

jneira commented Sep 1, 2021 •
edited
Loading

stack downloads it but fails to install:

Preparing to download ghc-8.10.7 ... ghc-8.10.7: download has begun
ghc-8.10.7:   88.28 MiB / 205.11 MiB ( 43.04%) downloaded...
ghc-8.10.7:  194.01 MiB / 205.11 MiB ( 94.59%) downloaded... 
ghc-8.10.7:  205.11 MiB / 205.11 MiB (100.00%) downloaded...
Downloaded ghc-8.10.7.
Unpacking GHC into /root/.stack/programs/x86_64-linux/ghc-8.10.7.temp/ ...
Configuring GHC ...
Installing GHC ...
/root/.stack/programs/x86_64-linux/ghc-8.10.7/lib/ghc-8.10.7/bin/ghc-pkg: error while loading shared libraries: libtinfo.so.6:
  cannot open shared object file: No such file or directory
Installing GHC ...                    make[1]: *** [install_packages] Error 127
Installing GHC ...                    make: *** [install] Error 2
Installing GHC ...                    Received ExitFailure 2 when running

@jneira
Copy link
Member Author

jneira commented Sep 1, 2021

It is building now: https://app.circleci.com/pipelines/github/jneira/haskell-language-server/713/workflows/3a1af3e2-a491-4598-8a75-8daeaa7ef496/jobs/6165 😅

@jneira jneira added the merge me Label to trigger pull request merge label Sep 1, 2021
@Ailrun Ailrun merged commit 577948f into haskell:master Sep 4, 2021
@jneira jneira mentioned this pull request Sep 4, 2021
Merged
@jneira
Copy link
Member Author

jneira commented Sep 7, 2021

@Mergifyio backport 1.3.0-hackage

@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2021

Command backport 1.3.0-hackage: failure

No backport have been created
GitHub App like Mergify are not allowed to create pull request where .github/workflows is changed.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pepeiborra pepeiborra pepeiborra approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jneira @pepeiborra @Ailrun