Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve incoming call for typeclass and type family instance #2162

Merged
merged 3 commits into from
Sep 6, 2021

Conversation

July541
Copy link
Collaborator

@July541 July541 commented Sep 6, 2021

Now the incoming call about type class/family will jump to the corresponding instance.

class F a where
  f :: a
instance F Bool where
  f = x
instance F Int where
  f = y

x = True
y = 3

Previously, If we request an incoming call for x, it will jump to line 2, but now it will go to line 4, the more direct result.

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks for the fix

@jneira jneira added the merge me Label to trigger pull request merge label Sep 6, 2021
@July541 July541 force-pushed the call-hierarchy-goto-instance branch from adca465 to 5585a74 Compare September 6, 2021 08:14
@July541
Copy link
Collaborator Author

July541 commented Sep 6, 2021

In the latest commit, I replaced constant delay with retry.

@July541 July541 requested a review from jneira September 6, 2021 08:17
@July541 July541 force-pushed the call-hierarchy-goto-instance branch 3 times, most recently from 7498d98 to b43ed7c Compare September 6, 2021 10:02
@mergify mergify bot merged commit 10d3554 into haskell:master Sep 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants