Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enable completions of local imports #2190

Merged
merged 16 commits into from
Sep 17, 2021

Conversation

alexnaspo
Copy link
Contributor

@alexnaspo alexnaspo commented Sep 13, 2021

Enable completions of local project modules

Import Development.IDE.<cursor-position> will show completions for locally built modules

@jneira
Copy link
Member

jneira commented Sep 13, 2021

Cant believe there is no feature request for this (or i dont find it) cause it is a nice one, thanks!

@alexnaspo
Copy link
Contributor Author

@pepeiborra - I updated to use GetKnownTargets. I'm guessing there might be a faster way to achieve this. I did not see a useStaleNoFile but I may be missing it.

@alexnaspo
Copy link
Contributor Author

Addressed the rebase @jneira

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@jneira jneira added the merge me Label to trigger pull request merge label Sep 16, 2021
@jneira
Copy link
Member

jneira commented Sep 16, 2021

/rerun-workflow Testing

@jneira
Copy link
Member

jneira commented Sep 16, 2021

/rerun-workflow Testing

@mergify mergify bot merged commit 6fed490 into haskell:master Sep 17, 2021
cdsmith pushed a commit to cdsmith/haskell-language-server that referenced this pull request Sep 21, 2021
* enable completions of local imports

* added unit test

* use HM.keys

* rename test

* Revert "enable completions of local imports"

This reverts commit a52894f.

* use GetKnownTargets

* clean up

* clean up

* leverage CachedCompletions over argument

* clean up

* clean

Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
Co-authored-by: alexnaspoleap <88672779+alexnaspoleap@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants