Skip to content

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Oct 9, 2021

With VSCode I get a WatchedFile notification immediately after of the TextDocumentDidChange notification, triggering a second rebuild unnecessarily.

To avoid this, let's filter out WatchedFile events for files of interest

With VSCode I get a WatchedFile notification immediately after of the TextDocumentDidChange notification, triggering a second rebuild unnecessarily
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks for the optimization

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Oct 9, 2021
@mergify mergify bot merged commit 514a7eb into master Oct 9, 2021
sdzx-1 pushed a commit to sdzx-1/haskell-language-server that referenced this pull request Oct 11, 2021
With VSCode I get a WatchedFile notification immediately after of the TextDocumentDidChange notification, triggering a second rebuild unnecessarily
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants