Skip to content

Enable top-level hover signature test #2435

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Dec 4, 2021
Merged

Enable top-level hover signature test #2435

merged 4 commits into from
Dec 4, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Dec 3, 2021

@jneira
Copy link
Member Author

jneira commented Dec 3, 2021

Results:

      top-level signature              #767:                                                              FAIL (1.02s)
        test/exe/Main.hs:3890:
        expected: Position {_line = 47, _character = 1}
         but got: Position {_line = 51, _character = 1}
        Use -p '/top-level signature              #767/' to rerun this test only.
      inner     signature              #767:                                                              FAIL (1.06s)
        test/exe/Main.hs:3896:
        failed to find: `Char` in hover message:

So top-level signature works but in another position and the inner fails as expected

And mark as broken inner one
@jneira jneira added the merge me Label to trigger pull request merge label Dec 3, 2021
@jneira jneira changed the title Enable outer/inner hover signature test Enable top-level hover signature test Dec 3, 2021
@jneira jneira requested a review from Ailrun December 4, 2021 14:03
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 53eb7da into master Dec 4, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants