Skip to content

Fix regression in Eval plugin and add test #2441

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 8, 2021
Merged

Fix regression in Eval plugin and add test #2441

merged 5 commits into from
Dec 8, 2021

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Dec 5, 2021 •
edited by gitpod-io bot
Loading

Fixes #2438 and includes a regression test

jneira
jneira approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

@pepeiborra pepeiborra force-pushed the eval-transitive branch 2 times, most recently from 82560a5 to ae571bc Compare December 6, 2021 09:07
@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Dec 7, 2021
@mergify mergify bot merged commit dcd2163 into master Dec 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@michaelpj michaelpj michaelpj left review comments

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
3 participants
@pepeiborra @jneira @michaelpj