Skip to content

Caching process update #2467

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
Dec 12, 2021
Merged

Conversation

Anton-Latukha
Copy link
Collaborator

@Anton-Latukha Anton-Latukha commented Dec 11, 2021

  • New code included & shares all source code that may be needed.

  • New config includes & shares all compiled deps that may be needed in workflows.

  • New config stores the source code separately, which means it gets stored one time.

Before this cache stored per Platform/GHC - the sources & compiled results
together. It is while sources not depend on platform or GHC, as sources are
platform & GHC agnostic. Because they were always bundled together
& sources took ~1/2-2/3 of that storage - cache stored multiple duplicates of the same
source code.

caching workflow now downloads, builds & shares all sources & all dependencies for all targets.

dist-newstyle so far is not included in to the cache, (what to cache from them can be looked into in the next updates).


@Anton-Latukha Anton-Latukha force-pushed the 2021-12-11-ci-upd-caching branch from 475c280 to 820d737 Compare December 11, 2021 16:25
Hopefully it would remove it & its files from being cached in the action. & also
not includde into environment.
For future caching configuraiton.
Sources are stored separately.

Before this cache was storing per Platform/GHC sources & compiled results
together. While deps sources does not depend on platform or GHC, they are
platform & GHC agnostic. Because sources & compiled results were stored togather
& sources took ~1/2-2/3 of that - cache stored multiple duplicates of the same
source code.

This config stores the source code separately.

And at the same time tries to store & share all source code which may be needed.
& all compiled deps that would be used in different workflows.
@Anton-Latukha Anton-Latukha force-pushed the 2021-12-11-ci-upd-caching branch 2 times, most recently from 9ac4c4a to 284e203 Compare December 11, 2021 17:43
@Anton-Latukha
Copy link
Collaborator Author

[skip circleci]

@Anton-Latukha Anton-Latukha force-pushed the 2021-12-11-ci-upd-caching branch from 284e203 to ff41e51 Compare December 11, 2021 18:05
@Anton-Latukha Anton-Latukha force-pushed the 2021-12-11-ci-upd-caching branch 2 times, most recently from 3098f20 to f97b4bd Compare December 11, 2021 19:06
@Anton-Latukha Anton-Latukha requested a review from jneira December 11, 2021 21:26
@Anton-Latukha
Copy link
Collaborator Author

Anton-Latukha commented Dec 11, 2021

This PR has WIP commits that allow development & review. To not merge the work commits. Please, it needs to be reviewed as a draft, before being marked available for merge.

@Anton-Latukha
Copy link
Collaborator Author

Ok. The working results in the PR are in: https://github.com/haskell/haskell-language-server/pull/2467/checks?sha=f97b4bd8794ac9e6ac4121b7cfed8ca92cce08c0

Now cleaning-up the PR from PR-work commits.

@Anton-Latukha Anton-Latukha force-pushed the 2021-12-11-ci-upd-caching branch from f97b4bd to 6483d96 Compare December 11, 2021 21:49
@Anton-Latukha Anton-Latukha marked this pull request as ready for review December 11, 2021 23:24
@Anton-Latukha Anton-Latukha requested a review from jneira December 12, 2021 12:55
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, separating sources from compiled code is really a good idea

@jneira jneira added the merge me Label to trigger pull request merge label Dec 12, 2021
@mergify mergify bot merged commit 0b6b5ec into haskell:master Dec 12, 2021
@Anton-Latukha
Copy link
Collaborator Author

Nice. After merge, it works as expected. Caching in the master started successfully. Happy about this.

@Anton-Latukha Anton-Latukha deleted the 2021-12-11-ci-upd-caching branch December 12, 2021 22:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants