Skip to content

Add space after comma when exporting a name #2547

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Conversation

sergv
Copy link
Contributor

@sergv sergv commented Dec 27, 2021

I felt that since hls-explicit-imports-plugin puts spaces after commas then this code action should also do so for consistency.

@jneira jneira requested a review from pepeiborra December 28, 2021 14:01
@jneira
Copy link
Member

jneira commented Dec 28, 2021

This is a fix for a whitespace inconsistency similar to described in #2399, thanks fo the contribution!

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, moreove looks better with a space imo

@michaelpj
Copy link
Collaborator

ghcide tests need updating

@sergv
Copy link
Contributor Author

sergv commented Dec 29, 2021

Thanks for catching the tests bit, I've fixed them.

@Anton-Latukha Anton-Latukha added the merge me Label to trigger pull request merge label Dec 29, 2021
@mergify mergify bot merged commit 65a8512 into haskell:master Dec 30, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants