Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for ghc 9.0.2 #2567
Add support for ghc 9.0.2 #2567
Changes from 4 commits
ddfede4
b956c3b
4caf4e1
bf280fa
77ffca7
87a8c9d
81e8aab
857edb9
23e6c82
9421c63
1d3acf3
3acfcf4
ad03a95
eaaafdb
ec80d94
0664619
9161fb8
d7c63f8
d58ea42
e377956
52a6a4d
c3b8a54
75e234a
d549a26
e3c41d9
c5e1f4b
51db994
eeb343d
6a77064
fba33f5
0c89870
5dcec89
b44f58b
bfedf97
4e535c7
2c7ac63
d2f0216
d210d99
dd335b6
6326efe
e27f56d
a5f5907
e694ebb
47e213c
c1fc2ee
f965d3c
3e75867
3a8e61e
3980b6d
6b8c707
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what would happen if we did this unconditionally but set the test suite to not be buildable on GHC 9 🤔 might error, might just succeed...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm i think it is good to build it even if the tests are gonna fail, or it will rot even with compile errors.
We are building all the test suites (with
tests: true
) and cabal doesnt haverunnable: false
😉There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, fair.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative is mark them as ignored or broken for that hls version using tasty modifiers, but we are not using them that way for now