test: Add regression tests for #2403 #2576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
many thanks for the test, I think it is enough to have it in ghcide |
guibou
force-pushed
the
regression_tests_for_2403
branch
from
ea73091 to
0c78028
Compare
|
I amended the commit to keep only the test in ghcide |
|
lgtm, many thanks |
Yes, I tested them and they were failing with a timeout. At least, that's what I though, but I'm trying to reproduce it right now and I do observe the failure in the log, but tests are stuck. Perhaps the timeout is too long for my patience. |
jneira
approved these changes
Jan 11, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work on #2569, this is regression test for type family completion.
I've implemented the tests in
ghcideandhaskell-language-server, not sure if that's the way or if I should drop one.