Skip to content

Use alpine in all sensible workflows #2640

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

jneira
Copy link
Member

@jneira jneira commented Jan 25, 2022

@jneira jneira marked this pull request as draft January 25, 2022 10:00
@jneira
Copy link
Member Author

jneira commented Jan 25, 2022

better than i expected, the test suite failed for ghc-9.0.2 in a th expression as expected:

 FAIL (1.68s)
        test/exe/Main.hs:3930:
        failed to find: `Identity` in hover message:
        
        '''haskell
        id :: forall a. a -> a
        '''
        
        *Defined in 'GHC.Base'*
         *(base-4.15.1.0)*
        
        
        [Documentation](file:///github/home/.ghcup/ghc/9.0.2/share/doc/ghc-9.0.2/html/libraries/base/GHC-Base.html#v:id)
        [Source](file:///github/home/.ghcup/ghc/9.0.2/share/doc/ghc-9.0.2/html/libraries/base/src/GHC.Base.html#id)
        
        * * *
        
        '''haskell
        _ :: Q Exp -> Q Exp
        '''

@jneira
Copy link
Member Author

jneira commented Jan 25, 2022

For 9.2.1 the ghcide passed but a stack invocation failed (maybe stack does not work in alpine?):

Failed to get project GHC version:CradleError {cradleErrorDependencies = [], cradleErrorExitCode = ExitFailure 1, cradleErrorStderr = ["Error when calling stack setup --silent","",""]}
    stack with ghc 8.10.7:                    FAIL
      Exception: readCreateProcess: hls-wrapper "--project-ghc-version" (exit 1): failed
      Use -p '/stack with ghc 8.10.7/' to rerun this test only.
No 'hie.yaml' found. Try to discover the project type!
Failed to get project GHC version:CradleError {cradleErrorDependencies = [], cradleErrorExitCode = ExitFailure 1, cradleErrorStderr = ["Error when calling stack setup --silent","",""]}
    stack with ghc 8.8.4:                     FAIL
      Exception: readCreateProcess: hls-wrapper "--project-ghc-version" (exit 1): failed
      Use -p '/stack with ghc 8.8.4/' to rerun this test only.

@Anton-Latukha
Copy link
Collaborator

Maybe install into Alpine coreutils to make it POSIX compliant.

Or simply lets remember that Alpine runs on BusyBox - that should be enough & leverage that specific to also test HLS running on BusyBox.

@jneira
Copy link
Member Author

jneira commented Feb 28, 2022

This is not applicable to actual release scripts

@jneira jneira closed this Feb 28, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore consistency in ci using alpine in all workflows
2 participants