Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Change Type Signature Plugin test suite for 9.2.1 #2761

Merged
merged 9 commits into from
Mar 7, 2022

Conversation

drsooch
Copy link
Collaborator

@drsooch drsooch commented Mar 7, 2022

This should fix the test errors for 9.2.1 and adds new test cases specifically for 9.2.1.

@drsooch drsooch changed the title Fix change type sig 921 Fix Change Type Signature Plugin test suite for 9.2.1 Mar 7, 2022
@drsooch drsooch marked this pull request as ready for review March 7, 2022 16:32
@drsooch drsooch linked an issue Mar 7, 2022 that may be closed by this pull request
@drsooch
Copy link
Collaborator Author

drsooch commented Mar 7, 2022

@michaelpj @pepeiborra ok finally. THIS is the one that adds the test suite... That's what I get for neglecting 9.2

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pepeiborra pepeiborra merged commit 82c1535 into haskell:master Mar 7, 2022
July541 pushed a commit to July541/haskell-language-server that referenced this pull request Mar 30, 2022
* Add change-type-signature test suite and enable alternate-number-format for 9.2

* Revert 9.2.1 enable tests for alternate-number-format

* Clean up test file

* GHC 9.2.1 test fixes

* -Wall fixes

* Add  to fix test failures

* Bump Version
@drsooch drsooch deleted the fix-change-type-sig-921 branch August 20, 2022 02:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Change Type Signature test suite to CI
2 participants